Poseidon v2.5 #152
Poseidon v2.5 #152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=========================================
Coverage ? 70.24%
=========================================
Files ? 18
Lines ? 2040
Branches ? 141
=========================================
Hits ? 1433
Misses ? 466
Partials ? 141
Continue to review full report at Codecov.
|
…ivated that by default for the update subcommand
There was a problem hiding this comment.
Oooookay, many files, but I've looked at all the diffs. Looks good! I've left some comments. Neither of them are severe, but perhaps we can briefly discuss whether we'd like to adjust the field order in the Janno data structure (see several comments about that).
| , jNrLibraries :: Maybe Int | ||
| , jDataType :: Maybe (JannoList JannoDataType) | ||
| , jCaptureType :: Maybe (JannoList JannoCaptureType) | ||
| , jGenotypePloidy :: Maybe JannoGenotypePloidy | ||
| , jGroupName :: JannoStringList |
There was a problem hiding this comment.
So I guess we could move these up. I think it wouldn't cause problems, since we don't match this gigantic data type by contractor anyway... right?
There was a problem hiding this comment.
Hmm, I guess I meant sex and group name
|
I opened issues for all contested points. But as I really want to move forward with this, I will merge now. I take the full responsibility. |
Here I collect the necessary changes for Poseidon v2.5. This is work in progress.
See poseidon-framework/poseidon-schema#42 for the discussion surrounding this upcoming release.
The changes so far only concern the
.jannofile.