Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder all relevant data types/instances/lists according to the new .janno column order #156

Closed
nevrome opened this issue Jan 28, 2022 · 4 comments
Labels

Comments

@nevrome
Copy link
Member

nevrome commented Jan 28, 2022

See the discussion in #152. The PR was lazy in that regard, which might cause maintenance issues eventually.

@robopsychologist
Copy link

Hey @nevrome! Its Eddy - we emailed and you mentioned there were some Poseidon issues that were open! If you want I can take a quick look at this one and submit a PR? Lets me get aquatinted with the code base a little bit :)

@nevrome
Copy link
Member Author

nevrome commented Mar 19, 2022

Hey Eddy - sounds good to me! The changes for Poseidon v2.5.0 were pretty massive and we left this tedious reordering task open. A PR to fix that would be very welcome.

The now correct order is defined here. In the code only the jannoHeader in Janno.hs features the correct order already, and there are numerous other contexts where this order is not established yet. Mostly in Janno.hs, but also once in CLI/List.hs.

We currently have #163 open, which also introduces some significant changes, but in an entirely different domain of the code. So I don't see a big danger for merge conflicts. Maybe it would nevertheless make sense to fork from there, because it is imho ready for merging 🤔

@nevrome nevrome added the good first issue Good for newcomers label Jan 11, 2023
@nevrome
Copy link
Member Author

nevrome commented Jan 11, 2023

I'll keep this issue around for now, because I think it's a good first issue if somebody wants to join the haskell coding here.

@nevrome
Copy link
Member Author

nevrome commented Mar 21, 2023

I think this is resolved now.

@nevrome nevrome closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants