You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey @nevrome! Its Eddy - we emailed and you mentioned there were some Poseidon issues that were open! If you want I can take a quick look at this one and submit a PR? Lets me get aquatinted with the code base a little bit :)
Hey Eddy - sounds good to me! The changes for Poseidon v2.5.0 were pretty massive and we left this tedious reordering task open. A PR to fix that would be very welcome.
The now correct order is defined here. In the code only the jannoHeader in Janno.hs features the correct order already, and there are numerous other contexts where this order is not established yet. Mostly in Janno.hs, but also once in CLI/List.hs.
We currently have #163 open, which also introduces some significant changes, but in an entirely different domain of the code. So I don't see a big danger for merge conflicts. Maybe it would nevertheless make sense to fork from there, because it is imho ready for merging 🤔
See the discussion in #152. The PR was lazy in that regard, which might cause maintenance issues eventually.
The text was updated successfully, but these errors were encountered: