Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can bypass modification residue checks with duplicate and edit #2803

Closed
ValWood opened this issue Feb 22, 2024 · 3 comments
Closed

can bypass modification residue checks with duplicate and edit #2803

ValWood opened this issue Feb 22, 2024 · 3 comments
Assignees

Comments

@ValWood
Copy link
Member

ValWood commented Feb 22, 2024

This isn't super urgent, but I noticed that I could copy and edit a modification, and the residues from the precious gene would be accepted, even if no residue at that position:

ticket canto residue check bypass
@kimrutherford
Copy link
Member

That's unfortunate! The simplest fix would be to remove the residue extension if you change the gene in the edit dialog. We could put a message box up explaining things. Would that be OK?

@ValWood
Copy link
Member Author

ValWood commented Feb 29, 2024

Yes I think that is safest.

kimrutherford added a commit that referenced this issue Mar 14, 2024
In the annotation edit dialog

Refs #2803
kimrutherford added a commit that referenced this issue Mar 14, 2024
When the gene is changed in the annotation edit dialog

Refs #2803
@kimrutherford
Copy link
Member

The simplest fix would be to remove the residue extension if you change the gene in the edit dialog. We could put a message box up explaining things.

I've implement this now. The change will be in the main Canto on Monday morning. I'll close the issue then.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants