Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't enforce annotations to be available, not even runtime-visible ones #194

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

uschindler
Copy link
Member

This is related to #193: The forbiddenapis checker fails on its own JAR file because the excluded runtime annotation can't be found. For annotations according to JLS we should not bail out on their existence: "Adding or removing annotations has no effect on the correct linkage of the binary representations of programs in the Java programming language."

@uschindler uschindler merged commit d9203a9 into main Mar 24, 2022
@uschindler uschindler deleted the pulls/annotation-fixes branch March 24, 2022 11:42
@uschindler uschindler self-assigned this Mar 24, 2022
@uschindler uschindler added the bug label Mar 24, 2022
@uschindler uschindler added this to the 3.3 milestone Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant