Add clone of IgnoreEmptyDirectories annotation to allow compiling forbiddenapis task with it #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… forbiddenapis task with it. This works around problems with Grdale 7.4+. Closes #189
|
This also set path sensitivity, which is unrelated, but for completeness and better caching (build cache) it should be done. |
|
I figured out we do not need to ship the annotation, we can remove it from JAR file. Works fine. Reason is that runtime annotations are required to be available during compilation, but at runtime they are still optional, see https://docs.oracle.com/javase/specs/jls/se8/html/jls-9.html#jls-9.6.4.2 and https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html#jls-13.5.7 "Adding or removing annotations has no effect on the correct linkage of the binary representations of programs in the Java programming language." |
reta
approved these changes
Mar 24, 2022
|
Thanks @reta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around problems with Gradle 7.4+.
See issue #189 for details.