Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

注释修正 #800

Merged
merged 7 commits into from
Nov 10, 2022
Merged

注释修正 #800

merged 7 commits into from
Nov 10, 2022

Conversation

reallovelei
Copy link
Contributor

Please provide issue(s) of this PR:
Fixes #

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

reallovelei and others added 7 commits November 7, 2022 18:41
等待 apiserver 都启动完成,再自注册。

1.完善代码规范
2.将cond.add 放到 apiserver的listen后。

完善代码规范
只提示了缺少参数,但是并不知道具体哪个参数出了问题。
看了代码才知道,dbpwd 从int转string的时候 失败了。
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #800 (c03bd7f) into main (9679e45) will increase coverage by 0.01%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   57.05%   57.06%   +0.01%     
==========================================
  Files         159      159              
  Lines       28808    28805       -3     
==========================================
+ Hits        16436    16439       +3     
+ Misses      10169    10165       -4     
+ Partials     2203     2201       -2     
Impacted Files Coverage Δ
store/sqldb/default.go 73.45% <76.92%> (+1.33%) ⬆️
store/sqldb/routing_config_v2.go 51.40% <0.00%> (+1.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chuntaojun chuntaojun added the code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment label Nov 10, 2022
@chuntaojun chuntaojun merged commit efe6137 into polarismesh:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants