Skip to content

Commit

Permalink
注释修正 (#800)
Browse files Browse the repository at this point in the history
* 等待 apiserver 都启动完成,再自注册。+ 格式化代码

等待 apiserver 都启动完成,再自注册。

1.完善代码规范
2.将cond.add 放到 apiserver的listen后。

完善代码规范

* import_format 格式化

* 添加Licensed

* 改用waitgroup

* 发现本地msyql密码是12345678,
只提示了缺少参数,但是并不知道具体哪个参数出了问题。
看了代码才知道,dbpwd 从int转string的时候 失败了。

* 注释单词修正
  • Loading branch information
reallovelei authored Nov 10, 2022
1 parent 74ddd88 commit efe6137
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions common/routing/routing.go
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ func CompositeRoutingV1AndV2(v1rule *apiv1.Routing, level1, level2,
}

// BuildV1RoutesFromV2 根据 v2 版本的路由规则适配成 v1 版本的路由规则,分为别 inBounds 以及 outBounds
// retuen inBound outBound revisions
// return inBound outBound revisions
func BuildV1RoutesFromV2(service, namespace string, entries []*v2.ExtendRoutingConfig) ([]*apiv1.Route, []*apiv1.Route, []string) {
if len(entries) == 0 {
return []*apiv1.Route{}, []*apiv1.Route{}, []string{}
Expand Down Expand Up @@ -468,7 +468,7 @@ func ConvertV1RouteToV2Route(route *apiv1.Route) *apiv2.RuleRoutingConfig {
}
}

// CompareRoutingV2
// CompareRoutingV2 比较两个路由的优先级。
func CompareRoutingV2(a, b *v2.ExtendRoutingConfig) bool {
if a.Priority != b.Priority {
return a.Priority < b.Priority
Expand Down

0 comments on commit efe6137

Please sign in to comment.