Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ISSUE #371] 补充单元测试 & 修复boltdb问题 #372

Merged
merged 9 commits into from
May 15, 2022
Merged

[ISSUE #371] 补充单元测试 & 修复boltdb问题 #372

merged 9 commits into from
May 15, 2022
+1,603 −513

Conversation

chuntaojun
Copy link
Member

@chuntaojun chuntaojun commented May 9, 2022 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #371

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Installation
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@chuntaojun chuntaojun added test Unit testing and integration testing code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment config Configuration Center service Service registration discovery, service governance install labels May 10, 2022
@chuntaojun chuntaojun linked an issue May 10, 2022 that may be closed by this pull request
单机版北极星，删除服务之后，再注册的时候注册不上去，然后解注册报错 #374
Closed
@chuntaojun chuntaojun changed the title fix: 补充单元测试 & 修复boltdb问题 [WIP] 补充单元测试 & 修复boltdb问题 May 10, 2022
@chuntaojun chuntaojun changed the title [WIP] 补充单元测试 & 修复boltdb问题 [ISSUE #371] 补充单元测试 & 修复boltdb问题 May 14, 2022
andrewshan
andrewshan approved these changes May 15, 2022
View reviewed changes
Copy link
Member

@andrewshan andrewshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewshan andrewshan merged commit 0eb7227 into polarismesh:main May 15, 2022
@chuntaojun chuntaojun deleted the test_auth branch October 21, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewshan andrewshan andrewshan approved these changes

@lepdou lepdou Awaiting requested review from lepdou

@houseme houseme Awaiting requested review from houseme

Assignees
No one assigned
Labels
code quality Prompt code readability, reduce repetitive code, improve code maintainability, code comment config Configuration Center service Service registration discovery, service governance test Unit testing and integration testing
Projects
None yet
Milestone
No milestone
2 participants
@chuntaojun @andrewshan