Fix false positive when asserting reference image with empty image #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuno-vieira
force-pushed
the
fix-false-positive-when-new-snapshot-is-empty
branch
from
450f629
to
e9840db
Compare
nuno-vieira
force-pushed
the
fix-false-positive-when-new-snapshot-is-empty
branch
from
e9840db
to
69489a9
Compare
nuno-vieira
changed the title
|
@mbrandonw @stephencelis Any update on this, please? 🙏 |
|
@mbrandonw @stephencelis Any update on this, please? |
Fab1n
approved these changes
Feb 25, 2022
This was referenced Mar 4, 2022
gabrielmoraees
approved these changes
Apr 22, 2022
niil-qb
pushed a commit
to quickbit/swift-snapshot-testing
that referenced
this pull request
Feb 23, 2023
Muhieddine-El-Kaissi
pushed a commit
to thumbtack/swift-snapshot-testing
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋
Bug Description
Unfortunately in the project that I'm working on, we encountered some false positives, where we thought that the tests were actually working, but they were not. What happened was that after some refactorings, some of the tests passed, but actually, the new reference images were the red empty image and the framework assumed that everything was okay.
In order to unit test this, I previously recorded a snapshot with content, and then verify against an empty view and check that it fails.
Fixes: #454, a duplicate of #414