Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive assertion when comparing reference with empty image #454

Closed
nuno-vieira opened this issue Apr 8, 2021 · 3 comments · Fixed by #453
Closed

False positive assertion when comparing reference with empty image #454

nuno-vieira opened this issue Apr 8, 2021 · 3 comments · Fixed by #453

Comments

@nuno-vieira
Copy link
Contributor

nuno-vieira commented Apr 8, 2021

Bug Description

Unfortunately in the project that I'm working on, we encountered some false positives, where we thought that the tests were actually working, but they were not. What happened was that after some refactorings, some of the tests passed, but actually, the new reference images had no size at all but the framework assumed that everything was okay. So there's a bug when the framework compares the current reference image with the empty red generated image.

I've opened a PR with the fix here: #453

@nuno-vieira nuno-vieira changed the title False positive assertion when comparing old reference with empty image False positive assertion when comparing reference with empty image Apr 8, 2021
@stephencelis
Copy link
Member

I think this is a dupe of #414

@nuno-vieira
Copy link
Contributor Author

I think this is a dupe of #414

Yes, it seems it is, sorry! Feel free to close this one or the #414 👍

@stephencelis
Copy link
Member

It's a good report, regardless! Thanks! We're working through a backlog now so just trying to focus our efforts :) Closing in favor of the original.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants