fix: terminal is not restarted if container if not running + state management #9793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nagement Signed-off-by: Philippe Martin <[email protected]>
feloy
requested review from
cdrage,
deboer-tim,
axel7083 and
SoniaSandler
and removed request for
a team
axel7083
reviewed
Nov 6, 2024
packages/renderer/src/lib/container/ContainerDetailsTerminal.svelte
Outdated
Show resolved
Hide resolved
axel7083
reviewed
Nov 6, 2024
Signed-off-by: Philippe Martin <[email protected]>
SoniaSandler
approved these changes
Nov 6, 2024
axel7083
approved these changes
Nov 6, 2024
feloy
added a commit
to feloy/podman-desktop
that referenced
this pull request
Nov 6, 2024
…nagement (podman-desktop#9793) * fix: terminal is not restarted if container if not running + state management Signed-off-by: Philippe Martin <[email protected]> * refactor: containerState as $derived Signed-off-by: Philippe Martin <[email protected]>
Merged
feloy
added a commit
that referenced
this pull request
Nov 6, 2024
fix: terminal is not restarted if container if not running + state management (#9793) * fix: terminal is not restarted if container if not running + state management Signed-off-by: Philippe Martin <[email protected]> * refactor: containerState as $derived Signed-off-by: Philippe Martin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Philippe Martin [email protected]
What does this PR do?
Screenshot / video of UI
terminal-restart-container.mp4
What issues does this PR fix or reference?
Fixes #9771
How to test this PR?
Start a container, go to the terminal page, check that the terminal works as expected
Stop the container
restart the container
the terminal should be working again
the app should work
no error should appear in the console
Tests are covering the bug fix or the new feature