fix: terminal is not restarted if container if not running + state ma…

…nagement (podman-desktop#9793) * fix: terminal is not restarted if container if not running + state management Signed-off-by: Philippe Martin <[email protected]> * refactor: containerState as $derived Signed-off-by: Philippe Martin <[email protected]>
feloy · Nov 6, 2024 · 24995e8 · 24995e8
1 parent 5c6c6ac
commit 24995e8
Showing 1 changed file with 15 additions and 12 deletions.
diff --git a/packages/renderer/src/lib/container/ContainerDetailsTerminal.svelte b/packages/renderer/src/lib/container/ContainerDetailsTerminal.svelte
@@ -28,11 +28,10 @@ let sendCallbackId: number | undefined;
 let terminalContent: string = '';
 let serializeAddon: SerializeAddon;
 let lastState = $state('');
-let containerState = $state(container);
+let containerState = $derived(container.state);
 
 $effect(() => {
-  containerState = container;
-  if (lastState === 'STARTING' && containerState.state === 'RUNNING') {
+  if (lastState === 'STARTING' && containerState === 'RUNNING') {
     restartTerminal();
   }
   lastState = container.state;
@@ -54,16 +53,20 @@ function receiveDataCallback(data: Buffer) {
 }
 
 function receiveEndCallback() {
-  // need to reopen a new terminal
-  window
-    .shellInContainer(container.engineId, container.id, receiveDataCallback, () => {}, receiveEndCallback)
-    .then(id => {
-      sendCallbackId = id;
-
-      shellTerminal?.onData(data => {
-        window.shellInContainerSend(id, data);
+  // need to reopen a new terminal if container is running
+  if (containerState === 'RUNNING') {
+    window
+      .shellInContainer(container.engineId, container.id, receiveDataCallback, () => {}, receiveEndCallback)
+      .then(id => {
+        sendCallbackId = id;
+        shellTerminal?.onData(data => {
+          window.shellInContainerSend(id, data);
+        });
+      })
+      .catch((err: unknown) => {
+        console.error('error starting shell', err);
       });
-    });
+  }
 }
 
 // call exec command