Feature/issue 85 - Add units to db records #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikki-t
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Units modifications look good. Does it make sense for me work on adding units into the API response under this PR or merge this PR and work on adding units to the API response under a different issue? Scratch that - I see there is already an issue open for this: #85. I will work on this issue after this PR is merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #85 Add variable units to API response
Description
Units for data measurements are not included in the standard shapefile fields. They are located in the shp.xml metadata file. We decided it was important to include the units as additional fields in each feature record.
Overview of work done
Modified parse_metadata_from_shpxml function introduced in #111 to also read the units from teh shp.xml file and add them as additional attributes on each feature as they are loaded into the database.
Overview of verification done
Updated unit tests to check for presence of units on and that they are the correct units for that field. Unit tests pass.
Overview of integration done
Deployed to SIT and loaded new granules into dynamodb. Verified that the units are now included in each database record.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request