Feature/issue 13 - Add SWORD version from shp.xml #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #13
Description
Add the SWORD version number to each database record
Overview of work done
Added new parse_metadata_from_shpxml function to swot_reach_node_shp io handler to read metadata from the *.shp.xml files.
Overview of verification done
Updated test_query unit test to explicitly check new sword_version value is present and correct. Added sword_version field to test values in constants file to ensure it is covered in both the read_shapefile tests and the test_hydrocron_database tests (ie test that it is read correctly from the file, and that it is loaded correctly into the db). All unit tests pass.
Overview of integration done
Deployed to SIT and verified newly loaded granules have new sword_version attribute with correct values.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request