Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Provisional Markers #338

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Add Provisional Markers #338

merged 2 commits into from
Mar 8, 2021

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Mar 2, 2021

Add a mechanism for labeling provisional items and text segments. Also cleanup the style sheet a bit with some comments.

\provisionalMarker     Add a provisional label to the margin
\markProvisional       Add a provisional label to the margin and highlight the provided text

\declareconstitemProvisional  Declare Constant - Provisional
\declareEnvarProvisional      Declare Envar - Provisional
\declareAttributeProvisional  Declare Attribute - Provisional

jjhursey added 2 commits March 2, 2021 09:12
@jjhursey
Add Provisional Markers
d648d06 
```
\provisionalMarker     Add a provisional label to the margin
\markProvisional       Add a provisional label to the margin and highlight the provided text
```

Signed-off-by: Joshua Hursey <[email protected]>
(cherry picked from commit 9986898)
@jjhursey
Add Provisional Commands for attributes, envars, constants
fd254fb 
```
\declareconstitemProvisional  Declare Constant - Provisional
\declareEnvarProvisional      Declare Envar - Provisional
\declareAttributeProvisional  Declare Attribute - Provisional
```

Also cleanup the style sheet a bit.

Signed-off-by: Joshua Hursey <[email protected]>
(cherry picked from commit ddb7e8f)
@jjhursey jjhursey added this to the PMIx v4.1 Standard milestone Mar 2, 2021
@jjhursey jjhursey requested a review from a team March 2, 2021 15:13
@jjhursey
Copy link
Member Author

jjhursey commented Mar 2, 2021

v4 version of PR #337

@rhc54
Copy link
Member

rhc54 commented Mar 2, 2021

Well now, this is new:

anyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading:
https://www.docker.com/increase-rate-limit

The command "docker pull jjhursey/pmix-standard" failed and exited with 1 during

@jjhursey
Copy link
Member Author

jjhursey commented Mar 2, 2021

Humm that shouldn't happen (I have the 'unlimited' plan) Let me check.

@jjhursey
Copy link
Member Author

jjhursey commented Mar 2, 2021

The rate limit issue is much bigger than I thought. I'll have to dig a bit to fix a resolution. It's looking like most people resolved the issue by abandoning Travis and moving to GitHub Actions.

@jjhursey jjhursey closed this Mar 2, 2021
@jjhursey jjhursey reopened this Mar 2, 2021
@jjhursey jjhursey requested a review from a team March 5, 2021 18:00
@jjhursey
Copy link
Member Author

jjhursey commented Mar 5, 2021

We will need this merged before we can merge PR #280

@jjhursey jjhursey mentioned this pull request Mar 5, 2021
Merged
@jjhursey jjhursey requested a review from rhc54 March 8, 2021 19:14
@jjhursey
Copy link
Member Author

jjhursey commented Mar 8, 2021

@rhc54 Can you give this a review as a v4 RM so we can merge? #337 has an example rendering. Thanks!

rhc54
rhc54 approved these changes Mar 8, 2021
View reviewed changes
Copy link
Member

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample output looks fine to me, so I trust the implementation

@jjhursey jjhursey merged commit fc6040c into pmix:v4 Mar 8, 2021
@jjhursey jjhursey deleted the prov-marker-v4 branch March 8, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhc54 rhc54 rhc54 approved these changes

Assignees
No one assigned
Labels
Editorial
Projects
None yet
Milestone
PMIx v4.1 Standard
Development

Successfully merging this pull request may close these issues.
2 participants
@jjhursey @rhc54