Add Provisional Markers #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` \provisionalMarker Add a provisional label to the margin \markProvisional Add a provisional label to the margin and highlight the provided text ``` Signed-off-by: Joshua Hursey <[email protected]>
``` \declareconstitemProvisional Declare Constant - Provisional \declareEnvarProvisional Declare Envar - Provisional \declareAttributeProvisional Declare Attribute - Provisional ``` Also cleanup the style sheet a bit. Signed-off-by: Joshua Hursey <[email protected]>
|
PR #280 will be our first Provisional item accepted. We need some LaTex markers to mark the text. Below is an example of what the markup looks like: |
|
That's a bit too colorful to my taste, but I have nothing better to propose. |
abouteiller
approved these changes
Mar 1, 2021
|
Yeah. We can tweak the coloring if we find something that we like better. This should give us the plumbing to make that an easy change. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a mechanism for labeling provisional items and text segments. Also cleanup the style sheet a bit with some comments.