Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection.open_direct is not working with latest amqp_client #73

Closed
ono opened this issue Aug 27, 2017 · 6 comments
Closed

Connection.open_direct is not working with latest amqp_client #73

ono opened this issue Aug 27, 2017 · 6 comments
Labels
wontfix

Comments

@ono
Copy link
Collaborator

ono commented Aug 27, 2017

The test fails with the amqp_client 3.6.11 on local.
@ono
Copy link
Collaborator Author

ono commented Aug 27, 2017

@binarin I haven't look into the issue properly but wonder if you can take a look as you wrote the PR. You will be able to reproduce the issue by running mix test with master branch on your local. Thanks!

@ono ono mentioned this issue Aug 27, 2017
Closed
@binarin
Copy link

binarin commented Aug 29, 2017

I'll try to investigate it this week. But looks like there is some problem in amqp_client from RabbitMQ itself.

@binarin binarin mentioned this issue Aug 29, 2017
Closed
@ono
Copy link
Collaborator Author

ono commented Aug 29, 2017

Thanks Alexey!

@ono ono mentioned this issue Feb 6, 2018
Closed
ono added a commit that referenced this issue Feb 7, 2018
@ono
Remove open_direct from Connection module as it doesn't work with
836978f 
the latest rabbit_client. This commit can be reverted once the bug
is fixed.

#73
@ono
Copy link
Collaborator Author

ono commented Feb 7, 2018

Remove open_direct from master for time being. Once it's sorted out on rabbit_client, we can revert 836978f .

@ono ono changed the title Connection.open_direct is not working with latest amqp_client? Connection.open_direct is not working with latest amqp_client Feb 7, 2018
@ono
Copy link
Collaborator Author

ono commented Apr 26, 2019

This appears to be addressed on 3.7.15 🙌

@nulian nulian mentioned this issue Feb 19, 2021
Closed
@ono ono added the wontfix label Sep 8, 2024
@ono
Copy link
Collaborator Author

ono commented Sep 8, 2024

I don't think there is high demand. Open for PR to support this but closing this for now.

@ono ono closed this as completed Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ono @binarin