Support direct connections to RabbitMQ #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This opens path to using this library for writing RabbitMQ plugins. Or as a performance improvements, escpecially when RabbitMQ is being run in embedded mode. Sadly there is no way to provide a reliable tests for this feature, as we need to know both the Erlang node-name of the broker and the Erlang cookie. And e.g. for Travis with disabled `sudo` it's not possible.
|
@binarin looking awesome! one request - could you add a test(s) for the function anyway? it'd be also great if you could also add a little note in the test for setting up local env to pass. Don't worry about Travis for now. I will add a tag to the test and make it to be skipped by default. |
|
I've added a test |
|
@binarin Superb! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60
This opens path to using this library for writing RabbitMQ plugins.
Or as a performance improvements, escpecially when RabbitMQ is being
run in embedded mode.
Sadly there is no way to provide a reliable tests for this feature, as
we need to know both the Erlang node-name of the broker and the Erlang
cookie. And e.g. for Travis with disabled
sudoit's not possible.