Plot does not appear in some cases if rangebreaks overlap #7270
Comments
mofojed
added a commit
to deephaven/web-client-ui
that referenced
this issue
Nov 27, 2024
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar - Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours - Added a ticket to plotly.js to take into account range breaks which may overlap: plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end - Needed for DH-16016 - Added a bunch of test cases --------- Co-authored-by: Vlad Babich <[email protected]>
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this issue
Jan 7, 2025
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar - Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours - Added a ticket to plotly.js to take into account range breaks which may overlap: plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end - Needed for DH-16016 - Added a bunch of test cases --------- Co-authored-by: Vlad Babich <[email protected]>
mofojed
added a commit
to mofojed/web-client-ui
that referenced
this issue
Jan 7, 2025
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar - Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours - Added a ticket to plotly.js to take into account range breaks which may overlap: plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end - Needed for DH-16016 - Added a bunch of test cases --------- Co-authored-by: Vlad Babich <[email protected]>
mofojed
added a commit
to deephaven/web-client-ui
that referenced
this issue
Jan 7, 2025
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar - Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours - Added a ticket to plotly.js to take into account range breaks which may overlap: plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end - Needed for DH-16016 - Added a bunch of test cases Co-authored-by: Vlad Babich <[email protected]>
mofojed
added a commit
to deephaven/web-client-ui
that referenced
this issue
Jan 7, 2025
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar - Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours - Added a ticket to plotly.js to take into account range breaks which may overlap: plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end - Needed for DH-16016 - Added a bunch of test cases --------- Co-authored-by: Vlad Babich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've created a Codepen for the issue: https://codepen.io/mofojed/pen/ZEgPJPN
In this case, the data spans a week, and range breaks are specified for a full holiday on Thursday, Nov 23, 2023 (Thanksgiving), and a half day on Friday, Nov 24, 2023. These specifications overlaps with other patterns for business days.
The chart does not appear. It looks like the rangebreaks that Plotly.js locates for the plot is:
Where some of those overlap. It looks like that isn't taken into account when calculating the breaks length, so when there's overlap it will not generate a valid break length:
plotly.js/src/plots/cartesian/autorange.js
Line 199 in 29ca37b
I think it would make sense to check for overlapping here. I'll see if it's possible to adjust holidays to not overlap with any existing business periods as well...
#5783 is similar
The text was updated successfully, but these errors were encountered: