fix: Partial holidays range breaks (#2297) #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Jan 7, 2025
mofojed
commented
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar
- Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours
- Added a ticket to plotly.js to take into account range breaks which may overlap: Plot does not appear in some cases if rangebreaks overlap plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end
- Needed for DH-16016
- Added a bunch of test cases
- Partial holidays were not generating valid range breaks, as they did not account for business periods specified on the calendar - Essentially we were adding another "closed" period that overlapped with time that was already outside of regular business hours - Added a ticket to plotly.js to take into account range breaks which may overlap: plotly/plotly.js#7270, as that would be nice to handle on their end, but this should be sufficient to resolve from our end - Needed for DH-16016 - Added a bunch of test cases --------- Co-authored-by: Vlad Babich <[email protected]>
mattrunyon
approved these changes
Jan 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.