Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new plone.app.vocabularies.MetadataFields vocabulary #62

Merged
merged 3 commits into from
Jun 30, 2020

Conversation

vincentfretin
Copy link
Member

@mister-roboto
Copy link

@vincentfretin thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@vincentfretin vincentfretin force-pushed the fix-i18n-columns-title branch from 47db69f to c680d49 Compare June 30, 2020 08:39
@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you have time after this is merged I would also add a PR or two to:

  1. update the package README (that lists all the vocabularies)
  2. some tests
    I see those activities as deferrable.

@vincentfretin
Copy link
Member Author

both done

@vincentfretin
Copy link
Member Author

@jenkins-plone-org please run jobs

@vincentfretin
Copy link
Member Author

Ok I'll start merging those 3 PR when jenkins is green.

@vincentfretin vincentfretin merged commit b31710c into master Jun 30, 2020
@vincentfretin vincentfretin deleted the fix-i18n-columns-title branch June 30, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants