consume the metadatafields vocabulary for translated columns #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
force-pushed
the
fix-i18n-columns-title
branch
from
ed1eaa6 to
b398e0a
Compare
ale-rt
reviewed
Jun 30, 2020
|
First merge plone/plone.app.vocabularies#62 then this one. |
…iterate on it to have the translated columns
vincentfretin
force-pushed
the
fix-i18n-columns-title
branch
from
0196d25 to
035b719
Compare
|
I squashed the commits. |
|
@jenkins-plone-org please run jobs |
ale-rt
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to plone/plone.app.contenttypes#559 to avoid code duplication.
I added plone.app.contenttypes to install_requires, this was already a dependency for the tests.
This PR needs to be tested and merged after plone/plone.app.contenttypes#559