Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZeroNet support #33

Closed
wants to merge 8 commits into from
Closed

Conversation

filips123
Copy link

Add support for ZeroNet site address. ZeroNet uses old-style Bitcoin addresses as site addresses.

Also see multiformats/multicodec#140. This PR depends on multiformats/js-multicodec#48.

@filips123
Copy link
Author

filips123 commented Jul 29, 2019

@pldespaigne PR for adding ZeroNet to multicodec package was merged and released. I created tests and updated multicodec version to correct one. I also updated demo with better support for onion, onion3 and zeronet. Can you now merge this PR?

I also linked my Python implementation from README and your package from my package. This is because I think that it would be good to notify developers about other implementations of the content hash in different languages.

@pldespaigne
Copy link
Owner

Hi @filips123 ! I don't have much time right now, but I will look at your PR before Sunday

@filips123
Copy link
Author

@pldespaigne Can you now check this?

@Gudahtt
Copy link

Gudahtt commented Sep 17, 2019

There is a conflict with README.md. Could you update this PR @filips123 ?

@pldespaigne
Copy link
Owner

I'm closing this PR because since v2.4.4, all multicodec are being encoded to utf-8 as a fallback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants