-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ZeroNet #7038
Add support for ZeroNet #7038
Conversation
The PR this depends on was now closed: pldespaigne/content-hash#33 I'm guessing this PR won't work until |
@Gudahtt Changes from that Pr were implemented in a slightly different way. Yes, |
@Gudahtt I updated |
895f5c0
to
eee50ef
Compare
@filips123 I've just rebased this and updated the lock file. How would we go about testing this? Would you mind testing this latest version? I'm not familiar with ZeroNet |
@Gudahtt What testing should this be? ZeroNet works so that the website is accessed at Testing on actual domains would be a bit harder because there are currently no ZeroNet ENS domains, and ENS manager PR is currently still not merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're going to merge this for now, but going forward we may ask that anybody adding additional protocols to the ENS resolver wait for the plugin system, and implement it as a plugin.
We do want to support EIP-1577, but we're not eager to take on the maintenance burden of supporting every possible protocol that an ENS name could map to. Plugins would allow us to safely accept additional protocols maintained by third parties, and it would also allow users to disable protocols if they'd prefer. We will likely migrate these existing protocols to plugins as well.
@Gudahtt Thank you! Do you also have any evidence when my ENS Manager PR (ensdomains/ui#23) will be merged? Because without it, there isn't any easy way to create such domains (although you can programatically manually register it with Web3 librrary). |
Unfortunately not! I'm not involved with that library. Best of luck getting that merged though. |
Ok, thanks anyway. |
Add support for ZeroNet site address in ENS domains.
This depends on pldespaigne/content-hash#33and it is related to ensdomains/ui#23. Changes incontent-hash
are now released in2.4.4
.