Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScalaTest 3.2, drop PhantomJS/Java 8/Scala 2.12, add MS Edge, add GithHub actions #373

Merged
merged 44 commits into from
Oct 7, 2022
Merged

ScalaTest 3.2, drop PhantomJS/Java 8/Scala 2.12, add MS Edge, add GithHub actions #373

merged 44 commits into from
Oct 7, 2022

Conversation

cheeseng
Copy link
Member

Please do not merge this, trying out sharable workflow as suggested by ihostage.

cheeseng added 16 commits April 15, 2022 22:44
@cheeseng
First version that works with ScalaTest 3.2.10, had to drop phantom j…
f0b67d3 
…s support.
@cheeseng
Got the tests to go green when run in Firefox and Chrome.
9eafdb5
@cheeseng
Changed firefoxProfile, chromeOptions, firefoxProfile in AllBrowsersP…
938fb51 
…erSuite and AllBrowsersPerTest to def.
@cheeseng
Merge branch 'main' of https://github.com/playframework/scalatestplus…
483ba2c 
…-play into feature-scalatest-3.2
@cheeseng
Updated to use ScalaTest 3.2.12.
dc882ee
@cheeseng
Adjusted according to @mkurz's comments.
de6946c
@cheeseng
Merge branch 'main' of https://github.com/playframework/scalatestplus…
a725191 
…-play into feature-scalatest-3.2
@cheeseng
Updated to use scalatest+selenium 3.2.12.1.
1d1c55d
@cheeseng
Added support for the newly added Edge browser.
6f3d2de
@cheeseng
Merge branch 'main' of https://github.com/playframework/scalatestplus…
cb0da65 
…-play into feature-scalatest-3.2
@cheeseng
Trying to add ci.yml.
ebd1b6f
@cheeseng
Added git fetch --unshallow to ci.yml.
0a73c3b
@cheeseng
Updated version of scalatest to 3.2.13, selenium 4.2.2, htmlunit 3.62…
d5f1b21 
….0 and mockito 4.6.1.
@cheeseng
Bumped selenium version up to 4.4.0, and htmlunit version to 3.64.0.
c3ca97e
@cheeseng
Merge branch 'main' of https://github.com/playframework/scalatestplus…
80c20ee 
…-play into feature-scalatest-3.2
@cheeseng
Added IntegrationPatient to MixedFixturesWsScalaTestClientSpec and On…
0a38abc 
…eServerPerSuiteWithOneBrowserPerTestSpec to prevent test failure flickerig.
@cheeseng cheeseng mentioned this pull request Sep 21, 2022
Merged
@mkurz mkurz force-pushed the experiment-share-workflow branch from 515f95c to 0e6e7d2 Compare October 6, 2022 09:03
@mkurz mkurz force-pushed the experiment-share-workflow branch from 0e6e7d2 to 966470f Compare October 6, 2022 09:30
ihostage
ihostage reviewed Oct 6, 2022
View reviewed changes
.github/workflows/ci.yml Outdated
cmd: sbt doc

test:
runs-on: macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz WDYT? I think we don't need a Mac OS for check compatibility with Safari. We can use Ubuntu from our reusable workflows and check all other browsers except Safari 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably yes, I am looking into this whole thing right now, give me a bit time.

@mkurz mkurz force-pushed the experiment-share-workflow branch from 4e297de to e89d7fe Compare October 6, 2022 19:47
@mkurz mkurz force-pushed the experiment-share-workflow branch from 3039d76 to 58fe20e Compare October 6, 2022 20:25
@mkurz mkurz force-pushed the experiment-share-workflow branch from 277202a to 8b51038 Compare October 6, 2022 22:11
@mkurz mkurz force-pushed the experiment-share-workflow branch 2 times, most recently from c09c4d3 to cfb517b Compare October 6, 2022 22:40
@mkurz mkurz force-pushed the experiment-share-workflow branch from 517916f to 3e41c20 Compare October 6, 2022 23:08
@mkurz mkurz mentioned this pull request Oct 6, 2022
Closed
23 tasks
@mkurz
Copy link
Member

mkurz commented Oct 6, 2022 •
edited
Loading

@cheeseng So I took a look and pushed a couple of commits. IMHO this should now be ready. What I did is

  • use our workflows that run with Ubuntu intead of macOs. As you can see in the logs it complains about missing drivers for Safari and Internet Explorer (:roll_eyes:), however the tests don't crash.
  • Upgraded to a unstable 2.9 Play milestone release that comes with latest Jackson.
  • Dropped Java 8, but test against Java 17
  • Dropped Scala 2.12

What do you think? Can you have a look and review my commits? Are you happy with the test output?

@ihostage Please review as well, thanks!

@cheeseng
Copy link
Member Author

cheeseng commented Oct 7, 2022

@mkurz Not an issue for me to skip Safari (just nice to have imho), and let's forget about IE :), Ubuntu should be able to run Edge though, it is good to go for me!

@mkurz mkurz changed the title [DO-NOT-MERGE] Experiment Share Workflow ScalaTest 3.2, drop PhantomJS/Java 8/Scala 2.12, add MS Edge, add GithHub actions Oct 7, 2022
@mkurz mkurz merged commit 9e4ccaa into playframework:main Oct 7, 2022
@mkurz
Copy link
Member

mkurz commented Oct 7, 2022

Thanks a lot @cheeseng.

@mkurz
Copy link
Member

mkurz commented Oct 7, 2022

@ihostage if you want something changed here let me know,we can do that in a a follow up PR.

This was referenced Oct 7, 2022
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihostage ihostage ihostage left review comments

@mkurz mkurz mkurz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cheeseng @mkurz @ihostage