Added check-binary-compatibility to CI.

playframework · Oct 6, 2022 · 0e6e7d2 · 0e6e7d2
1 parent f5eb41d
commit 0e6e7d2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,6 +9,10 @@ jobs:
     with:
       cmd: sbt validateCode
 
+  check-binary-compatibility:
+    name: Binary Compatibility
+    uses: playframework/.github/.github/workflows/binary-check.yml@v2
+
   check-docs:
     name: Docs
     uses: playframework/.github/.github/workflows/cmd.yml@v2
@@ -19,6 +23,7 @@ jobs:
     runs-on: macos-latest
     needs:
       - "check-code-style"
+      - "check-binary-compatibility"
       - "check-docs"
     steps:
     - name: Checkout

diff --git a/build.sbt b/build.sbt
@@ -55,6 +55,11 @@ lazy val mimaSettings = Seq(
     ProblemFilters.exclude[IncompatibleMethTypeProblem]("org.scalatestplus.play.PlaySpec.*"),
     ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.scalatestplus.play.PlaySpec.*"),
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalatestplus.play.MixedPlaySpec.*"),
+    // Dropping deprecated phantom-js support.
+    ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSFactory"),
+    ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSFactory$"),
+    ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSInfo"),
+    ProblemFilters.exclude[MissingClassProblem]("org.scalatestplus.play.PhantomJSInfo$")
   ),
   mimaPreviousArtifacts := previousVersion.map(organization.value %% name.value % _).toSet
 )