Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some Lightbend references #471

Merged
merged 5 commits into from
Jan 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/assets/css/main.styl
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@import "../stylesheets/oss-banners-036.css"
@import "nib"
@import "util/_index"

Expand Down
4 changes: 0 additions & 4 deletions app/controllers/Application.scala
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,6 @@ class Application @Inject()(
}
}

def support = Action { implicit request =>
Ok(html.support())
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely removed the support page because it just promotes Lightbend's commercial offering regarding Play (which does not exist anymore). The other links to Discuss, Discord and Stack Overflow are just duplicated with the "Get Involved" page.

def getInvolved = Action { implicit request =>
Ok(html.getInvolved())
}
Expand Down
1 change: 0 additions & 1 deletion app/views/commonSidebar.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
<li><a href="https://discuss.playframework.com">Discuss Play Forum</a></li>
<li><a href="//discord.gg/g5s2vtZ4Fa">Discord Server</a></li>
<li><a href="https://stackoverflow.com/questions/tagged/playframework">Stack Overflow</a></li>
<li><a href="https://www.lightbend.com/lightbend-platform-subscription">Lightbend Platform Subscription</a></li>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bye bye last point:

</ul>
<@hn>Contribute</@hn>
<ul>
Expand Down
6 changes: 3 additions & 3 deletions app/views/getInvolved.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ <h1>How you can help</h1>
<div class="links">

<h3 class="opencollective">Donate to our Open Collective</h3>
<a href="//opencollective.com/playframework#section-contributors">35+ backers</a>
<a href="//opencollective.com/playframework#section-contributors">75+ backers</a>
<p>
Play uses <a href="//opencollective.com/playframework">Open Collective</a> to collect donations from sponsors. These funds are used to pay contributors and cover project costs, openly and transparently.
Individuals and companies alike can support Play financially by <a href="@routes.Application.sponsors">becoming backers or premium sponsors</a>.
Expand All @@ -38,7 +38,7 @@ <h3 class="discord">Join the Discord chat</h3>
</p>

<h3 class="stackoverflow">Contribute to Stack Overflow</h3>
<a href="//stackoverflow.com/questions/tagged/playframework">10,500+ questions</a>
<a href="//stackoverflow.com/questions/tagged/playframework">17,000+ questions</a>
<p>
Stack Overflow is a Q&amp;A site for programmers. Stack Overflow has a very active community of people asking and answering <a href="//stackoverflow.com/questions/tagged/playframework">questions about Play</a>. Users can vote on each others' contributions and earn reputation points.
</p>
Expand All @@ -53,7 +53,7 @@ <h3 class="bugs">Report bugs</h3>
</p>

<h3 class="patch">Patch the core</h3>
<a href="//github.com/playframework/playframework/graphs/contributors">600+ committers</a>
<a href="//github.com/playframework/playframework/graphs/contributors">900+ committers</a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git shortlog -sn | wc -l

<p>
Play's code and documentation is hosted on <a href="//github.com/playframework/playframework">GitHub</a>. It's easy to <a href="@reverseRouter.latest(None, "BuildingFromSource")">get the code and build Play from source</a>. Play development is discussed on the <a href="//groups.google.com/forum/#!forum/play-framework-dev"><span class="mailingList">play-framework-dev</span> mailing list</a>. You can ask on the list if you have any questions, or you can also chat to Play contributors through the <a href="//discord.gg/g5s2vtZ4Fa">play-contributors</a> channel.
</p>
Expand Down
2 changes: 1 addition & 1 deletion app/views/index.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ <h2>Proven in production.</h2>
From startups to enterprises, Play powers some of the most innovative web sites. Play is proven, reliable and scalable.
</p>
<ul>
<li>Production support by Lightbend</li>
<li>Easy to deploy and scale</li>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have a better idea, let me know.

<li>Many cloud deployment options</li>
<li>Used in mission-critical apps</li>
</ul>
Expand Down
16 changes: 0 additions & 16 deletions app/views/lightbendBanner.scala.html

This file was deleted.

9 changes: 1 addition & 8 deletions app/views/main.scala.html
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,12 @@

</head>
<body class="@scope">
<!--[if lt IE 7]>
<p class="outdated">You are using an outdated browser. <a href="http://browsehappy.com/">Upgrade your browser today</a> or <a href="//www.google.com/chrome/browser/">install Google Chrome Frame</a> to better experience this site.</p>
<![endif]-->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh crap, I have to upgrade to IE 7 now.


@lightbendBanner()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the "Akka Serverless" banner.

<header id="navigation">
<div class="wrapper">
<a href="/" id="logo">Lightbend</a>
<a href="/" id="logo">Play Framework</a>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is invisible anyway, seems like SEO.

<nav id="sections">
<a href="@routes.Application.gettingStarted">Try Play</a>
<a href="@reverseRouter.index(None)">Documentation</a>
<a href="@routes.Application.support">Support</a>
<a href="@routes.Application.getInvolved">Get Involved</a>
</nav>
<nav id="social">
Expand Down
36 changes: 0 additions & 36 deletions app/views/support.scala.html

This file was deleted.

1 change: 0 additions & 1 deletion conf/routes
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ GET / controllers
# Pages
GET /download controllers.Application.download
GET /getting-started controllers.Application.gettingStarted
GET /support controllers.Application.support
GET /code controllers.Code.index
GET /get-involved controllers.Application.getInvolved
GET /sponsors controllers.Application.sponsors
Expand Down
2 changes: 1 addition & 1 deletion public/markdown/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@ Generally, all bug fixes, improvements and new features will go to the master br
* The change only affects the documentation
* The change fixes a regression that was introduced in a previous stable release from that branch
* The change fixes a bug that impacts significant number of members of the open source community with no simple work arounds available
* Any other reason that Lightbend deems appropriate
* Any other reason that Play steering committee deems appropriate

All backports and other commits to stable branches, in addition to satisfying the regular contributor guidelines, must also be binary and source compatible with previous releases on that branch. The only exception to this is if a serious bug is impossible to fix without breaking the API, for example, a particular feature is not possible to use due to flaws in the API.
1 change: 0 additions & 1 deletion public/stylesheets/oss-banners-036.css

This file was deleted.