Remove some Lightbend references #471

mkurz · 2022-01-20T18:04:49Z

It's time.
The reason why I would like to remove most references to Lightbend is to make clear to potential sponsors the project is now community maintained.

There are other things to update (just grep for Lightbend in the repo), however lets do that step-by-step.

mkurz · 2022-01-20T18:07:04Z

app/controllers/Application.scala

-  def support = Action { implicit request =>
-    Ok(html.support())
-  }
-


I completely removed the support page because it just promotes Lightbend's commercial offering regarding Play (which does not exist anymore). The other links to Discuss, Discord and Stack Overflow are just duplicated with the "Get Involved" page.

mkurz · 2022-01-20T18:08:00Z

app/views/commonSidebar.scala.html

@@ -14,7 +14,6 @@
    <li><a href="https://discuss.playframework.com">Discuss Play Forum</a></li>
    <li><a href="//discord.gg/g5s2vtZ4Fa">Discord Server</a></li>
    <li><a href="https://stackoverflow.com/questions/tagged/playframework">Stack Overflow</a></li>
-    <li><a href="https://www.lightbend.com/lightbend-platform-subscription">Lightbend Platform Subscription</a></li>


Bye bye last point:

mkurz · 2022-01-20T18:08:26Z

app/views/getInvolved.scala.html

@@ -53,7 +53,7 @@ <h3 class="bugs">Report bugs</h3>
                </p>

                <h3 class="patch">Patch the core</h3>
-                <a href="//github.com/playframework/playframework/graphs/contributors">600+ committers</a>
+                <a href="//github.com/playframework/playframework/graphs/contributors">900+ committers</a>


git shortlog -sn | wc -l

mkurz · 2022-01-20T18:08:45Z

app/views/index.scala.html

@@ -144,7 +144,7 @@ <h2>Proven in production.</h2>
                From startups to enterprises, Play powers some of the most innovative web sites.  Play is proven, reliable and scalable.
            </p>
            <ul>
-                <li>Production support by Lightbend</li>
+                <li>Easy to deploy and scale</li>


If you have a better idea, let me know.

mkurz · 2022-01-20T18:12:27Z

app/views/main.scala.html

@@ -48,19 +48,12 @@

    </head>
    <body class="@scope">
-        <!--[if lt IE 7]>
-            <p class="outdated">You are using an outdated browser. <a href="http://browsehappy.com/">Upgrade your browser today</a> or <a href="//www.google.com/chrome/browser/">install Google Chrome Frame</a> to better experience this site.</p>
-        <![endif]-->


Oh crap, I have to upgrade to IE 7 now.

mkurz · 2022-01-20T18:12:55Z

app/views/main.scala.html

        <header id="navigation">
            <div class="wrapper">
-                <a href="/" id="logo">Lightbend</a>
+                <a href="/" id="logo">Play Framework</a>


This is invisible anyway, seems like SEO.

mkurz · 2022-01-20T18:13:24Z

app/views/main.scala.html

-        <![endif]-->
-
-        @lightbendBanner()
-


Removing the "Akka Serverless" banner.

mkurz · 2022-01-20T18:13:56Z

app/views/main.scala.html

                    <a href="https://www.lightbend.com/legal/licenses" target="_blank">Licenses</a> |
                    <a href="https://www.lightbend.com/legal/terms" target="_blank">Terms</a> |
                    <a href="https://www.lightbend.com/legal/privacy" target="_blank">Privacy Policy</a> |
                    <a href="@routes.Application.cookie">Cookie Listing</a> |
                    <a class="optanon-toggle-display">Cookie Settings</a>
                </p>
+                <p>
+                    &copy; 2011-2021 Lightbend Inc., since 2022 the original author or authors from the Play Framework project
+                </p>


That's the copyright we came up with in the slack channel a couple of weeks ago.

I use 2011 instead of 2009, because that's when Typesafe came in. Also the first commit to Play 2 was in Sept. 2011

mkurz · 2022-01-20T18:15:00Z

public/markdown/contributing.md

@@ -19,8 +19,7 @@ Before making a contribution, it is important to make sure that the change you w

 ### Procedure

-1. Make sure you have signed the [Lightbend CLA](http://www.lightbend.com/contribute/cla); if not, sign it online.


See playframework/play-meta#210

octonato

Looks good, except for the copyright header. I don't know what needs to be done.

octonato · 2022-01-20T22:07:58Z

public/markdown/contributing.md

@@ -41,10 +40,10 @@ Before making a contribution, it is important to make sure that the change you w
        * Features are forever, always think about whether a new feature really belongs to the core framework or if it should be implemented as a module
        * Code must conform to standard style guidelines and pass all tests (see [Run tests](documentation/latest/BuildingFromSource#run-tests))
    6. New files must:
-        * Have a Lightbend copyright header in the style of ``Copyright (C) 2009-2019 Lightbend Inc. <https://www.lightbend.com>``.
+        * Have a copyright header in the style of ``2011-2021 Lightbend Inc., since 2022 the original author or authors from the Play Framework project``.


I don't get that this sentence means.

I also don't know what we should do with the copyright header. I guess all existing files should keep the Lightbend copyright. After they are edited, they should include Lightbend and something else, eg: Play Framework Organisation.

New files can have Play Framework Organisation only.

We need to learn more about it.

The sentence is similar to what JHipster uses, please see our conversation on slack we had 2 month ago: https://typesafe.slack.com/archives/CFPVDLR41/p1637077983073200

I thought about changing the copyright of all files on the play master branch to this wording (or similiar). So the 2.8.x branch still is "under control" by Lightbend, however upcoming 2.9 is community. Also the sentences says "unitl 2021 this is Lightbend stuff, after that community"

Anyway, I will revert this sentence for now but deploy the rest already.

Renato look here:
https://github.com/jhipster/generator-jhipster/blob/9f8da38a6251416c9b700f35b9533b157d537b4d/cli/commands.js#L2-L5

* Copyright 2013-2022 the original author or authors from the JHipster project. * * This file is part of the JHipster project, see https://www.jhipster.tech/ * for more information. *

Lets track that here: playframework/play-meta#211

mkurz · 2022-01-20T22:32:32Z

Alright, the copyright isn't touched anymore, we can change it later.

mkurz · 2022-01-20T22:39:53Z

Almost forgot: deployed.

mkurz added 4 commits January 20, 2022 19:01

Remove support page

900d6cd

Remove Lightbend Akka Serverless banner

415d6f9

Remove more references to Lightbend

52bad6d

Update statistics

ea0e948

mkurz commented Jan 20, 2022

View reviewed changes

app/views/main.scala.html

<![endif]-->

@lightbendBanner()

Copy link

Member Author

mkurz Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the "Akka Serverless" banner.

mkurz commented Jan 20, 2022

View reviewed changes

octonato reviewed Jan 20, 2022

View reviewed changes

Update contributing guidelines

247b0b0

mkurz force-pushed the remove_some_lb_references branch from 08a7f82 to 247b0b0 Compare January 20, 2022 22:27

mkurz merged commit feab0d8 into playframework:master Jan 20, 2022

mkurz deleted the remove_some_lb_references branch January 20, 2022 22:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove some Lightbend references #471

Remove some Lightbend references #471

mkurz commented Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

octonato left a comment

octonato Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022

mkurz Jan 20, 2022 •

edited

Loading

mkurz Jan 20, 2022

mkurz commented Jan 20, 2022

mkurz commented Jan 20, 2022

		@@ -19,8 +19,7 @@ Before making a contribution, it is important to make sure that the change you w

		### Procedure

		1. Make sure you have signed the [Lightbend CLA](http://www.lightbend.com/contribute/cla); if not, sign it online.

Remove some Lightbend references #471

Remove some Lightbend references #471

Conversation

mkurz commented Jan 20, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octonato left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkurz Jan 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkurz commented Jan 20, 2022

mkurz commented Jan 20, 2022

mkurz Jan 20, 2022 •

edited

Loading