-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI fix: footer alignment on mobile #1498
Conversation
BundleMonUnchanged files (7)
No change in files bundle size Final result: ✅ |
Thanks @hirusi! This footer is duplicated in the website repo so it should be fixed there as well |
Ahh, you're right. On it. |
Sorry @ukutaht, I don't see this on the landing website? I did refer to that implementation to get this correct here, and it seemed OK. |
The problem appeared on the Analytics software primarily because of a difference in the number of list items for the first block ("Why Plausible?"). |
Ahh I see. I updated the one on the home page as that's the one I knew how to update. I didn't get to update the one in app. The footer on the home page is the correct one and the one we should use in app too. Perhaps you could simply replicate what we have on the home page in app too? |
That's exactly what I've done. :) With the exception of a small change, that is, different top margin, since one column is shorter here compared to the home page. I'll share some screenshots later to explain more clearly. |
Ah OK then it's all good |
Changes
This fixes the issue raised in #1272, specifically:
I have opted for a bit of a hacky approach as far as the alignment for the "Comparisons" column goes (
mt-32
). If that is unwarranted, let me know please.Tested with
Tests
Changelog
Documentation