Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI fix: footer alignment on mobile #1498

Merged
merged 2 commits into from
Nov 30, 2021

Conversation

MaybeThisIsRu
Copy link
Contributor

@MaybeThisIsRu MaybeThisIsRu commented Nov 28, 2021

Changes

This fixes the issue raised in #1272, specifically:

footer menus need to be aligned properly

I have opted for a bit of a hacky approach as far as the alignment for the "Comparisons" column goes (mt-32). If that is unwarranted, let me know please.

Tested with

  • Firefox 94
  • Edge 96
  • Chromium 96

Tests

  • This PR does not require tests

Changelog

  • Entry has been added to changelog

Documentation

  • This change does not need a documentation update

@bundlemon
Copy link

bundlemon bot commented Nov 28, 2021

BundleMon

Unchanged files (7)
Status Path Size Limits
static/css/app.css
515.56KB -
static/js/dashboard.js
283.82KB -
static/js/app.js
12.13KB -
static/js/embed.host.js
5.53KB -
static/js/embed.content.js
5KB -
tracker/js/plausible.js
748B -
static/js/applyTheme.js
314B -

No change in files bundle size

Final result: ✅

@ukutaht
Copy link
Contributor

ukutaht commented Nov 29, 2021

Thanks @hirusi!

This footer is duplicated in the website repo so it should be fixed there as well

@MaybeThisIsRu
Copy link
Contributor Author

Ahh, you're right. On it.

@MaybeThisIsRu
Copy link
Contributor Author

Sorry @ukutaht, I don't see this on the landing website?

image

I did refer to that implementation to get this correct here, and it seemed OK.

@MaybeThisIsRu
Copy link
Contributor Author

MaybeThisIsRu commented Nov 29, 2021

The problem appeared on the Analytics software primarily because of a difference in the number of list items for the first block ("Why Plausible?").

@metmarkosaric
Copy link
Contributor

Ahh I see. I updated the one on the home page as that's the one I knew how to update. I didn't get to update the one in app. The footer on the home page is the correct one and the one we should use in app too. Perhaps you could simply replicate what we have on the home page in app too?

@MaybeThisIsRu
Copy link
Contributor Author

That's exactly what I've done. :)

With the exception of a small change, that is, different top margin, since one column is shorter here compared to the home page.

I'll share some screenshots later to explain more clearly.

@ukutaht
Copy link
Contributor

ukutaht commented Nov 30, 2021

Ah OK then it's all good

@ukutaht ukutaht merged commit 17563e9 into plausible:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants