Mobile issues (realtime dashboard, favicon etc)

[metmarkosaric]

• A way for anonymous/logged-out viewers to see domain name on the embed/public mobile version. right now they only see the favicon and would be nice by tapping the favicon they can see the full domain name too

• if i'm logged in and tap on the favicon to display the full domain / other sites i have, i cannot tap the favicon again to close that little menu. i must tap on another site or somewhere else on the display to close the menu. would be nice if i can tap the favicon again

• The text headings for unique visitors and pageviews in "realtime" view overflow

• footer menus need to be aligned properly

• top pages:

[Vigasaurus]

The issues with the top stat headers I have fixed in my graph overhaul, should be coming soonish.

[metmarkosaric]

Another little issue is on the home page for non-logged in users. the "2 months free" overflows so should be placed either above or below "yearly billing"

[MaybeThisIsRu]

@metmarkosaric - got it. think I'll start tackling this new stuff this weekend/early next week.

[MaybeThisIsRu]

The text headings for unique visitors and pageviews in "realtime" view overflow

To confirm, this has been tackled by @Vigasaurus?

[MaybeThisIsRu]

if i'm logged in and tap on the favicon to display the full domain / other sites i have, i cannot tap the favicon again to close that little menu. i must tap on another site or somewhere else on the display to close the menu. would be nice if i can tap the favicon again

50-50 on this, but I doubt this functionality was available before? I'm looking into it either way. Might be a simple JavaScript fix/enhancement.

[MaybeThisIsRu]

if i'm logged in and tap on the favicon to display the full domain / other sites i have, i cannot tap the favicon again to close that little menu. i must tap on another site or somewhere else on the display to close the menu. would be nice if i can tap the favicon again

@ukutaht - I see two conflicting handlers for this one:

analytics/assets/js/dashboard/site-switcher.js

Lines 18 to 22 in 5f6553c

	componentDidMount() {
	this.populateSites();
	document.addEventListener("keydown", this.handleKeydown);
	document.addEventListener('mousedown', this.handleClick, false);
	}

analytics/assets/js/dashboard/site-switcher.js

Lines 41 to 46 in 5f6553c

	handleClick(e) {
	if (this.dropDownNode && this.dropDownNode.contains(e.target)) return;
	if (!this.state.open) return;
	this.setState({open: false})
	}

...and, this:

analytics/assets/js/dashboard/site-switcher.js

Line 141 in 5f6553c

<button onClick={this.toggle.bind(this)} className={`inline-flex items-center md:text-lg w-full rounded-md py-2 leading-5 font-bold text-gray-700 dark:text-gray-300 focus:outline-none transition ease-in-out duration-150 ${hoverClass}`}>

analytics/assets/js/dashboard/site-switcher.js

Lines 63 to 71 in 5f6553c

	toggle() {
	if (!this.props.loggedIn) return;
	this.setState({open: !this.state.open})
	if (!this.state.sites) {
	this.populateSites();
	}
	}

---

I would favor the toggle method -- as adding event listeners is generally not very React-y.

[MaybeThisIsRu]

I have a PR open for this now, but let me know if you need this changed please.

[MaybeThisIsRu]

A way for anonymous/logged-out viewers to see domain name on the embed/public mobile version. right now they only see the favicon and would be nice by tapping the favicon they can see the full domain name too

I have an early peek here. I'm not sure how well this fits into all use cases for the site switcher -- maybe @ukutaht has input here?

The idea is to show the site switcher even for guests (as is the case for embeds), but remove the hotkey keyboard hint (1, 2, 3).

This also means I'll have to update the site switcher to show an arrow (or another icon) so guests have an idea by looking at the area that this is something that can be toggled for additional info.

[MaybeThisIsRu]

I believe fixes to all the listed issues here have been merged?

[metmarkosaric]

I believe fixes to all the listed issues here have been merged?

hi @hirusi! i think the only one left is the text headings for unique visitors and pageviews in "realtime" view where they overflow

[metmarkosaric]

also the one where non-logged-in only see the favicon and cannot know the full domain name of the site... but probably not important if there's no simple way to showcase the domain on tap. adding the site switcher seems unnecessary just to showcase the domain

[MaybeThisIsRu]

I believe fixes to all the listed issues here have been merged?

hi @hirusi! i think the only one left is the text headings for unique visitors and pageviews in "realtime" view where they overflow

Has that not been fixed by @Vigasaurus?

[MaybeThisIsRu]

also the one where non-logged-in only see the favicon and cannot know the full domain name of the site... but probably not important if there's no simple way to showcase the domain on tap. adding the site switcher seems unnecessary just to showcase the domain

You're right! My bad here.

Let me see if I can come up with something. Perhaps a tooltip on tap?

[metmarkosaric]

Has that not been fixed by @Vigasaurus?

There are a couple PRs waiting so could be part of that but at least it's not live yet.

Let me see if I can come up with something. Perhaps a tooltip on tap?

Yeah, if it's not possible to have the design we have for logged in users (but without the whole site switcher), then something simple could work too. Thanks!

[Vigasaurus]

Has that not been fixed by @Vigasaurus?

There are a couple PRs waiting so could be part of that but at least it's not live yet.

Yeah - it's part of #1364 if I recall correctly.

[metmarkosaric]

closing as the realtime design issues have now been fixed so nothing remaining here

[MaybeThisIsRu]

I left a message on our Element group a few days ago re: #1272 (comment). Probably should have commented here too...

Is that not of interest anymore?

[metmarkosaric]

ah sorry! we switched to Basecamp for internal comms few months ago so haven't been on Element. the other ideas we discussed are more important than this one (email reports on mobile, icons for os/browser...) but if there's a way to fix this one too at the same time, sure let's do it