Refactor Translation Logic and Make It More Testable #962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689
There were some things noted about the translation helper that needed work. So I went ahead and gave it some more love to make it easier to work with logic-wise. There are still things that can be improved around it, but the helper methods and logic that was refactored should make things a decent bit clearer and easier to test.
Some tests were added to help make sure issues around locale files not mapping properly between their short code value and the file name could be caught earlier.
Changes Made: