Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Up: Break Translation Helper Into Parts and Add UTs for It #689

Closed
3 tasks done
pjkaufman opened this issue Apr 17, 2023 · 1 comment · Fixed by #962
Closed
3 tasks done

Clean Up: Break Translation Helper Into Parts and Add UTs for It #689

pjkaufman opened this issue Apr 17, 2023 · 1 comment · Fixed by #962
Assignees
Labels
code cleanup resolution/update-made A change has been made that should resolve this issue or request

Comments

@pjkaufman
Copy link
Collaborator

pjkaufman commented Apr 17, 2023

The translation helper is a utility that should help with translating the Linter into different languages. We need to make sure that the core of the logic works and makes sense. In order to do this and make it maintainable, I would like to do the following:

  • Create a folder for the logic for the translation helper rather than having it all be in one file and break it into parts
  • Add UTs for the testable parts of the translation helper
  • Update documentation to include that you need to run npm run build in order to be able to run npm run translate and add a full example of translating into a language
@pjkaufman
Copy link
Collaborator Author

I have some changes that have been pushed to their own branch. They help reduce the complexity of the translation helper and add some UTs for it. It still needs an addition for the documentation around how to contribute translations for new keys, but once that gets done, I should be good to merge it.

@github-project-automation github-project-automation bot moved this from Queue to In Next Release in Obsidian Linter Dec 4, 2023
@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label Dec 4, 2023
@pjkaufman pjkaufman moved this from In Next Release to Released in Obsidian Linter Dec 13, 2023
@pjkaufman pjkaufman self-assigned this Dec 13, 2023
@pjkaufman pjkaufman moved this from Released to Previous Release in Obsidian Linter Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant