Fix: Paragraph Blank Lines Not Being Consistent Across List Types and Different List Indicators
#1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist items and ordered lists as well as some types of ordered and unordered lists
pjkaufman
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1014
There was an issue where the logic for
Paragraph Blank Lineswas not looking for indented unordered, ordered, or checklist list items. It was also not looking for ordered list items that had an end list style of). There was also an issue where it did not consider+and*to be list indicators at the start of line when followed by a space or tab. This was simple to fix by swapping tostartsWithListMarkerRegexas a regex match since it handles these scenarios already.Changes Made:
startsWithListMarkerRegexinstead of some of the other list checks