Bug: Paragraph blank lines Not Behaving Uniformly with Different List Indicators and Types

[liangzh-404]

before change:

after chagne

I personally think that the behavior of an ordered list makes more sense to me.

[pjkaufman]

Hey @liangzh-404 . I believe that logic is entirely based on the parser itself. Could you provide the source content and before and after? Spacing matters at the end of each line, so that could cause the discrepancy you are seeing.

[liangzh-404]

@pjkaufman test case I used

• abc
  abc
  bb

1. abc
   abc
   bb

[pjkaufman]

I took a look at the logic and I see the issue. This logic seems to have been written a ways back before we were properly handling all list types. It seems that it is properly recognizing ordered lists that start with numbers and have a period after them. But it is only looking for list items that start with - or - . So that logic needs to be updated to properly ignore all list items.

[pjkaufman]

Dev note:
Update the match regex for paragraph blank lines for list items to match all possible list item indicators (not having to be the very start of the line) and update the regex for ordered list items to also account for 9) and 9) as well since nested list items should also be ignored.

[pjkaufman]

I believe that I have a simple fix for this since we already have regex to check this exact scenario in one go: startsWithListMarkerRegex. I just need to add more UTs to make sure that all list item types (orderd, unordered, and check lists) get accounted for.

[pjkaufman]

I have merged in the potential fix. It should be in the next release and on master. Please let us know if there are any issues with either of them. Thanks!