Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed InterateIndex to IterateIndexes (resolves issue #462) #560

Conversation

qtuu
Copy link
Contributor

@qtuu qtuu commented Oct 1, 2019

Also renamed the corresponding StoreTest and StoreTracker-Methods to comply with the new name.

This change resolves issue 462

Also renamed the corresponding StoreTest and StoreTracker-Methods to comply with the new name.
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #560 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   90.65%   90.61%   -0.05%     
==========================================
  Files         201      201              
  Lines       15116    15116              
==========================================
- Hits        13704    13697       -7     
- Misses       1126     1133       +7     
  Partials      286      286
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 81.25% <ø> (ø) ⬆️
Libplanet/Store/LiteDBStore.cs 89.87% <ø> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.68% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 94.26% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 56.83% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 99.14% <100%> (ø) ⬆️
Libplanet/Net/Protocols/KademliaProtocol.cs 64.24% <0%> (-1.4%) ⬇️
Libplanet/Net/Swarm.cs 83.34% <0%> (-0.14%) ⬇️

added changelog entry and link to issue 462
Copy link
Contributor

@earlbread earlbread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! I left a comment.

earlbread
earlbread previously approved these changes Oct 2, 2019
Copy link
Contributor

@earlbread earlbread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Moved up the urls for issue 555 and PR 558 to Version 0.7.0.
@qtuu
Copy link
Contributor Author

qtuu commented Oct 2, 2019

Thank you for taking the time to review my changes. :)

@earlbread earlbread merged commit da65903 into planetarium:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants