Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IStore.IterateIndex to IStore.IterateIndexes #462

Closed
longfin opened this issue Aug 27, 2019 · 3 comments
Closed

Rename IStore.IterateIndex to IStore.IterateIndexes #462

longfin opened this issue Aug 27, 2019 · 3 comments
Labels
good first issue Good for newcomers hacktoberfest Newcomer-welcoming issues for Hacktoberfest

Comments

@longfin
Copy link
Member

longfin commented Aug 27, 2019 •
edited
Loading

Context:

how about keep ForkIndexes() in this PR and rename IterateIndex() to IterateIndexes() in other PR?
@longfin longfin added the good first issue Good for newcomers label Aug 27, 2019
@dahlia
Copy link
Contributor

dahlia commented Aug 27, 2019

I believe the link is incorrect.

@longfin
Copy link
Member Author

longfin commented Aug 27, 2019

I believe the link is incorrect.

Fixed.

@dahlia dahlia added the hacktoberfest Newcomer-welcoming issues for Hacktoberfest label Sep 26, 2019
@qtuu qtuu mentioned this issue Oct 1, 2019
Merged
earlbread added a commit that referenced this issue Oct 2, 2019
@earlbread
Merge pull request #560 from qtuu/#462-Rename-IStore.IterateIndex-to-…
da65903 
…IStore.IterateIndexes

Renamed InterateIndex to IterateIndexes (resolves issue #462)
@limebell
Copy link
Member

closed by #560

limebell pushed a commit to limebell/libplanet that referenced this issue Jul 7, 2021
Merge pull request planetarium#462 from riemannulus/hotfix/ignore-0tx…
142c3f6 
…-block

Ignore block without transaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest Newcomer-welcoming issues for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dahlia @longfin @limebell