-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Block Plugin upgrade 2.x to 3.x leaves invalid block contexts #5523
Comments
…block sidebar contexts
…block sidebar contexts
@ctgraham, forgive me for losing track of this one -- what is the status of the open PRs linked here? |
Heh. I was just looking for that horrible I think these are still good for merge. |
I've added Travis tests to |
With apologies, @ctgraham, I'm deferring this yet again -- I'm about to release 3.2.1-3 on more urgent matters and don't want to bring in a large last-minute merge. My fault! |
After many deferrals -- and with apologies to @ctgraham, who put a lot of thought and effort into this -- I'm going to close this issue. We removed the 2.x to 3.x upgrade toolset with the release of 3.3.0, so this would need to be fixed in 3.2.x or older, which we're not actively maintaining. For anyone encountering this issue, there is a proposed fix in pkp/customBlockManager#61. |
Describe the bug
The upgrade from 2.x to 3.x does not modify the block context of custom blocks, leaving them orphaned if they existed in
BLOCK_CONTEXT_RIGHT_SIDEBAR
orBLOCK_CONTEXT_HOMEPAGE
To Reproduce
Steps to reproduce the behavior:
What application are you using?
OJS 3.1.2
Additional information
Original contexts were:
pkp-lib/classes/plugins/BlockPlugin.inc.php
Lines 16 to 18 in 097e08e
Contexts for 3.1.2 were:
pkp-lib/classes/plugins/BlockPlugin.inc.php
Lines 16 to 17 in 957d926
But, only
BLOCK_CONTEXT_SIDEBAR
is considered:pkp-lib/controllers/listbuilder/settings/BlockPluginsListbuilderHandler.inc.php
Lines 89 to 91 in 957d926
But then this constant is entirely removed in 3.2:
a76bac7#diff-70caff5ef9a513397af1833a3e2a3c7c
The text was updated successfully, but these errors were encountered: