Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#5523, pkp/customBlockManager#17: refactor block names and settings, migrate block sidebar contexts #60

Open
wants to merge 3 commits into
base: stable-3_1_2
Choose a base branch
from

Conversation

ctgraham
Copy link
Contributor

@ctgraham ctgraham commented Mar 3, 2020

On upgrade to version 1.3.0-0 or later, review existing custom blocks and migrate each to a uniquely generated block plugin name.

Reset all unrecognized sidebar contexts to the BLOCK_CONTEXT_SIDEBAR.

Resolves pkp/pkp-lib#5523 and #17 .

@asmecher
Copy link
Member

asmecher commented Mar 3, 2020

@nate, would you mind reviewing #61 and #60? I'm not sure if the constant removal was intentional.

@ctgraham
Copy link
Contributor Author

ctgraham commented Mar 3, 2020

n.b.: I currently think the removal of BLOCK_CONTEXT_SIDEBAR is intentional and I actively remove the "context" setting for 3.2.
n.b: I have played with this on 3.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants