-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with input and display of keywords #1828
Comments
I've updated the title and description of this issue to reflect that the keywords as metadata is handled in a separate issue. |
Hi @bozana, As to the second, I could clarify that. Now entering a new keyword is 'physically' bound to certain keys. Whereas theoretically this should be bound to certain characters (",", ";" etc) wherever they may be in the keyboard layout. So if this is a problem, I would propose to make 'ENTER' the only key that triggers a new keyword. Is it OK? |
@Ph-We, with the 3rd-party control (Tag-It) that we're using, changing key-bindings unfortunately isn't an option. It might be possible to find a more flexible control, but it's potentially a lot of work. One option might be to contribute back to the upstream project to add support for keybinding flexibility, but long story short, it's not an easy change. |
Hi, In my OJS 3.0.1 also no keywords on article page. How to fix it? |
@novikoffav, this issue is scheduled for OJS 3.0.2, so keywords won't be displayed on article pages until that release. If you want, watch this issue and when it gets some developer attention you can be notified (and possibly apply the changes to your own install). |
Hi @asmecher, |
Hi @NateWr, I know, thanks. But that issue is not labeled as OJS related. And it is not related to keywords proper. |
@Ph-We, regarding:
Where do you expect to see them in the OAI interface (i.e. what DC element)? |
Hi @asmecher, I am talking about DC/GS metadata in OJS 3 (article pages). In OJS 2 those looked like this:
So it was not a DC element. It was HighWire, adopted by Google Scholar. And that is correct if we are talking about indexing in GS. |
If I understand it correctly, there should then be added something like this, but for keywords, or this replaced with keywords: https://github.com/pkp/ojs/blob/master/plugins/generic/googleScholar/GoogleScholarPlugin.inc.php#L102-L106 -- the keywords are apparently not get in the same way, with getSubject, as in 2.4.x, but with getKeywords in SubmissionKeywordDAO, right @asmecher? |
UPD: Actually, in OJS 2 keywords were written both as HighWire (GS) and Dublin Core. The latter looked like this:
And that was correct too. |
Hmm, it looks like we have options for both Keywords and Subjects in OJS 3, and the Subjects field behaves as you expect WRT indexing, but Keywords does not. I don't recall any reasoning for having both of these -- I suppose it's possible that we merged OMP and OJS 2.x metadata concerns and ended up with redundant fields? |
Hi @asmecher, |
@asmecher, maybe current |
DC.Subject is just the same as citation_keywords. I mean, DC.Subject is the field for keywords in Dublin Core (DC). See here: http://purl.org/dc/elements/1.1/subject While citation_keywords is a HighWire (GS) field. |
@Vitaliy-1, it's in |
@bozana, are you still working on this one? |
@asmecher, I never did -- I just fixed the migration issue. |
@NateWr, I can also do 4) if you would tell me where and how to display them best :-) |
@bozana That'd be great. I'd think they'd be best just below or above the abstract. You should be able to do it with the following HTML, requiring no additional styling. <div class="item abstract">
<p><strong>Keywords:</strong> <a href="#">first</a>, <a href="#">second</a>, <a href="#">third</a></p>
</div> |
I would vote either for the 'above the abstract' option, or for putting keywords somewhere between the galley and 'published' blocks. |
I arrive late to this thread... so sorry in advance if I'm only adding noise to the discussion. @NateWr I have doubts here:
I found this discussion... but unfortunately it's really old: Did you search for "best practices" (or "patterns" or "components" or whatever they like to call them) to see how others are dealing with this. It's very close to a blog's tag so from an html perspective, we can adopt the most extended solution, don't you think? |
Google is not indexing keywords at all. So they are needed mostly for
authors for better navigation inside the journal.
2017-08-22 18:38 GMT+03:00 Marc Bria <[email protected]>:
… I arrive late to this thread... so sorry in advance if I'm only adding
noise to the discussion.
@NateWr <https://github.com/natewr> I have doubts here:
- Is "strong" the right tag for the label? https://www.w3schools.com/
tags/tag_strong.asp
- Should be better (for theming) build a ul-li list for each keyword?
- Why not adding "rel=tag"?
Did you search for "best practices" (or "patterns" or "components" or
whatever they like to call them) to see how others are dealing with this.
It's very close to a blog's tag so from an html perspective, we can adopt
the most extended solution, don't you think?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1828 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATtU8_zXWq2iYQF0z5qAlMpGFiGEAfjWks5savYLgaJpZM4KALVi>
.
|
I suppose it probably would be good to follow the <div class="item doi">
<span class="label">
Keywords:
</span>
<span class="value">
first, second, third
</span>
</div> But we'll need to update the CSS for the default theme and defaultManuscript to place them inline (like the DOIs). (@bozana, you can give me a nod when you want me to do that.)
The keyword data should be available for themers to build their own HTML output.
I jumped the gun above. We won't actually have a page for each keyword to view articles in that keyword in 3.1. So there won't be any links there. It's worth considering when we do have keyword-based browsing, but we'll need to consider other grouping strategies (sections, subjects) before settling on a |
I did look at eLife, PlosOne and UbiquityPress. Only Ubiquity was even displaying keywords, so they don't seem to be a high priority, and Ubiquity is probably just displaying them because they were part of OJS 2. Still, they're doing |
I think Google indexes keywords, but they do not use them for ranking pages indexed. Google Scholar should index both Dublin Core and HighWire (GS) tags. At least, Arlitsch & OBrien recommend adding the appropriate metatags, and they did a lot of research in this field :) UPD: I double checked the document, Google sent to us: |
BTW, taking a look to Plos and UbiquityPress (this last one is tricky because as you said is an OJS, so is like looking ourselves) is good but, apart of our small academic universe, we also need to keep an eye on cutting edge cms (like wordpress, drupal, joomla...) to see what are becoming a new standards. @NateWr I know you are very familiar with wordpress, so if you think is not the right moment to change our ojs' list-items-pattern I'm ok with your decision. |
PR for 3) and 4) from the original issue: |
@NateWr, I displayed the keywords in front of abstract and in the same way and size as DOIs. If I should change that, just tell me... Could you review the PR above? It also solves the other issue mentioned here: to consider keywords for DC and GoogleScholar indexing. |
pkp/pkp-lib#1828 consider keywords for display, DC and GoogleScholar indexing
I think I can close this issue -- if something from the discussion should be addressed later, maybe to open a new issue? |
pkp/pkp-lib#1828 consider keywords for display, DC and GoogleScholar indexing
Hi!
Here are the issues found for keywords functionality:
http://forum.pkp.sfu.ca/t/ojs3-keywords-are-not-displaying-anywhere/20125/3
The text was updated successfully, but these errors were encountered: