Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#1828 consider keywords for display, DC and GoogleScholar indexing #1518

Merged
merged 6 commits into from
Sep 1, 2017

Conversation

bozana
Copy link
Contributor

@bozana bozana commented Sep 1, 2017

Copy link
Contributor

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just the one comment on the label then you can merge it. 👍

{if !empty($keywords[$currentLocale])}
<div class="item keywords">
<span class="label">
{translate key="article.subject"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keywords label should have a : after it like the DOI, eg - Keywords: <list of keywords>.

@bozana bozana merged commit 049fc9c into pkp:master Sep 1, 2017
@bozana bozana deleted the 1828 branch September 1, 2017 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants