Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LabelMixin to Season, Episode, Artist, and Track objects #872

Merged
merged 7 commits into from
Feb 27, 2022

Conversation

meisnate12
Copy link
Contributor

@meisnate12 meisnate12 commented Jan 13, 2022

Description

Following up on #868 this adds the LabelMixin to the Season, Episode, Artist, and Track objects as well.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16
Copy link
Collaborator

Has anyone checked that applying these hidden labels doesn't break sharing restrictions for shared users?

@meisnate12
Copy link
Contributor Author

I didn't test music libraries but for shows I add a label to a season and an episode and restricted that label from a test user and the user was still able to view both the season and the episode, which leads me to believe they're just ignored. and when the label is added to the show the whole thing is ignored

@JonnyWong16
Copy link
Collaborator

My other concern is users can get stuck with labels that they have no idea how to remove.

Just as an example, if Plex-Meta-Manager adds a feature that can label episodes they are now stuck with the labels unless they know how to remove them again with Plex API. Those hidden labels will continue to show up in search filters and sharing restrictions. There is no way to remove those labels in the UI.

It's part of the same reason why #510 and #658 have not been merged.

@meisnate12
Copy link
Contributor Author

I mean thats a very valid concern as my plan was to add labels to seasons and episodes in order to be able to tell what has had an image overlay on it and what hasn't. Ill include a way to remove all labels using PMM so if they got into the situation with PMM they could at least get back out using the same software.

@JonnyWong16 JonnyWong16 changed the title Add LabelMixin to Season, Artist, and Track objects Add LabelMixin to Season, Episode, Artist, and Track objects Jan 24, 2022
@JonnyWong16
Copy link
Collaborator

Please test my changes make labels a searchable filter.

@meisnate12
Copy link
Contributor Author

i ran a few tests on each type of item and they were all searchable using filters

@JonnyWong16 JonnyWong16 merged commit 2f101e3 into pkkid:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants