-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LabelMixin to Season, Episode, Artist, and Track objects #872
Conversation
Has anyone checked that applying these hidden labels doesn't break sharing restrictions for shared users? |
I didn't test music libraries but for shows I add a label to a season and an episode and restricted that label from a test user and the user was still able to view both the season and the episode, which leads me to believe they're just ignored. and when the label is added to the show the whole thing is ignored |
My other concern is users can get stuck with labels that they have no idea how to remove. Just as an example, if Plex-Meta-Manager adds a feature that can label episodes they are now stuck with the labels unless they know how to remove them again with Plex API. Those hidden labels will continue to show up in search filters and sharing restrictions. There is no way to remove those labels in the UI. It's part of the same reason why #510 and #658 have not been merged. |
I mean thats a very valid concern as my plan was to add labels to seasons and episodes in order to be able to tell what has had an image overlay on it and what hasn't. Ill include a way to remove all labels using PMM so if they got into the situation with PMM they could at least get back out using the same software. |
Please test my changes make labels a searchable filter. |
i ran a few tests on each type of item and they were all searchable using filters |
Description
Following up on #868 this adds the
LabelMixin
to theSeason
,Episode
,Artist
, andTrack
objects as well.Type of change
Checklist: