Add ability to upload theme music #658
Conversation
Added theme endpoints Fixed comments in art endpoints.
|
This class supports many things Does everything has a theme? |
According to this old documentation, only movie, tv show, and artist (not tv episode or tv season) https://web.archive.org/web/20150113085312/http://dev.plexapp.com/docs/agents/models.html Where should I put it to limit what items can have a theme? |
|
Think I found where... videos.py |
Remove themes from base and add to video.py and audio.py
Add ability to upload theme music to movies and tv shows
Add ability to upload theme songs to artists
|
Sorry, I don't understand why the checks are failing... |
|
Themes should be moved to a mixin similar to #648. |
|
This isn't something that we can do in the UI currently and the way you'd undo it is potentially destructive to the item. From my experience of playing this feature, you'd have to dance the item away to clear out the themes. I'd assume when danced, because the item is given a new ratingKey, all it's history is gone. It's why I didn't create a PR then and posted the feature request instead. Maybe add a disclaimer of using the feature or guidance on what to do (dance) if you regret your decision. For Shows libraries, where there is a toggle for the library, you can turn off themes. For non Show libraries you can't. So unless you upload a silent audio file you're stuck with a theme on that item or you dance. |
|
Closing as #879 replaces this and I longer have access to the repo I made these changes in. |
Added theme endpoints
Fixed comments in art endpoints.