Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change LibrarySection.reload() to reload in-place #855

Merged
merged 3 commits into from
Nov 21, 2021

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Nov 14, 2021

Description

  • Changes the behaviour of LibrarySection.reload() to reload in-place which mimics PlexObject.reload().
  • LibrarySection.edit() does not auto-reload after editing to mimic PlexObject.edit().

Ref #851

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@JonnyWong16 JonnyWong16 merged commit a8136d2 into pkkid:master Nov 21, 2021
@JonnyWong16 JonnyWong16 deleted the bugfix/library_reload branch November 21, 2021 01:52
@JonnyWong16 JonnyWong16 mentioned this pull request Dec 20, 2021
9 tasks
blacktwin added a commit that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant