-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library editing updates #837
Conversation
… libraryEditUpdates
TODO: Add tests |
Still needs tests.
|
build location list inside path checking loop
the result of posting this request is nothing to reduce confusion add a check for locations size after removals
Tests: Create library with multiple paths with valid paths Create library with multiple paths with an invalid path Create library with no path Add path(s) to test library with an invalid path Remove path(s) to test library with an invalid path Remove path(s) to test library with valid paths Add path(s) to test library with valid paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more tests:
-
BadRequest
when trying to remove all locations. -
edit
directly withkwargs['location']
. -
addLocations
with aPath
object. -
removeLocations
with aPath
object. -
isBrowsable
with aPath
object.
addLocations with a Path object
I don't think we should include |
Description
Adding convenience methods to add and remove location(s) (paths) to a library. Updating library
add()
method to allow for muliple locations on creation of library.Fixes or addresses #827
Example
Type of change
Please delete options that are not relevant.
Checklist: