Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reviews, Extras, and Online Media Source Options #530

Merged
merged 66 commits into from
Jun 7, 2021
Merged

Conversation

blacktwin
Copy link
Collaborator

@blacktwin blacktwin commented Jul 17, 2020

Adding support for Plex's newly added Reviews.
Adding support for finding Extras (related hub information from videos) in videos.
Adding support for finding Online Media Sources related information from videos. Tracks found on Tidal from video.

Fixes #564

@blacktwin blacktwin marked this pull request as draft July 17, 2020 01:24
@blacktwin
Copy link
Collaborator Author

Draft until I can add some tests. May want to add a toggle for the Online Media Sources if it isn't already available.

@jfenton
Copy link

jfenton commented Aug 12, 2020

Hi, is it possible or intended to stream/download Trailers?

I note that Extras are Playable and can be .play()'d, but it's not possible to:
.download()
(AttributeError: 'Extra' object has no attribute '_prettyfilename')
nor
.getStreamURL()
(plexapi.exceptions.Unsupported: Fetching stream URL for clip is unsupported.)

@blacktwin
Copy link
Collaborator Author

.download() won't work without some overhauling of the method. The error of _prettyfilename not being present is because there isn't a file to pull a filename from. .getStreamURL() will work if you simply add clip to the supported types within the getStreamURL method. From there you can use the url to download the trailer.

Downloading trailers/extras is outside the scope of this PR. This PR is just adding support for getting to some of Plex's new features. If you have a bug, request, or question having to do with this project please create an Issue.

@mabuckman
Copy link

Having the ability to opt out of media sources would be great 👍

@blacktwin blacktwin marked this pull request as ready for review August 30, 2020 06:32
@JonnyWong16 JonnyWong16 dismissed jjlawren’s stale review June 7, 2021 00:59

Requested changes implemented

@JonnyWong16 JonnyWong16 merged commit b2f018b into master Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't determine how to get movie extras?
6 participants