Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't determine how to get movie extras? #564

Closed
13steinj opened this issue Sep 8, 2020 · 2 comments · Fixed by #530
Closed

Can't determine how to get movie extras? #564

13steinj opened this issue Sep 8, 2020 · 2 comments · Fixed by #530

Comments

@13steinj
Copy link

13steinj commented Sep 8, 2020

Describe the issue

The documentation makes note of a class plex.video.Clip, but I can't tell what this is for (movie extra?)

If not a movie extra, I can't find a way to get movie extras.

Code snipppets

server = PlexServer(...)
movie = server.library.section("Movies").all()[0]
# how to get movie extra?

Expected behavior
N/A / Extra is considered a Clip and it's not being found

Enviroment (please complete the following information):

  • OS: [e.g. Linux, Windows, Docker] Windows
  • Plex version [eg. version 1.19.3.2852] 1.20.something I don't believe it's relevant but if it is, just let me know where to find it
  • Python Version [e.g. 2.7.15, 3.6] 3.6.5
  • PlexAPI version [e.g. 3.6.0] 4.0.0

Additional context

If this is a case of just not being implemented, I'll gladly submit a full PR as long as a maintainer lets me know what features are wanted (besides the obvious regarding an object for the data).

Extras' response data is included in the film's XML response. Some extras are implemented as ones given from Plex with links to some external archive, so I don't know if those should be distinguished from plain extras on the filesystem or not.

@blacktwin
Copy link
Collaborator

#530 adds support for Extra, Reviews, and Online Media Sources (Tidal, etc.) Feel free to try it out.

@13steinj
Copy link
Author

13steinj commented Sep 9, 2020

#530 looks great, thanks! I'll check it out. Feel free to close, I'll leave it to you to decide whether to close this issue now or when that PR gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants