-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First steps to convert MARC schema to Avram format #371
Conversation
As listed at <timathom/marc-schema#1>: - wrap the list of fields in a root object with key 'fields' and add key family with value 'marc' - rename key 'name' to 'label' - rename key 'values' to 'codes' - rename key 'staticValues' to 'positions' - remove key 'fixed', its value is implied by non-existence of 'subfields'
2c52821
to
f928321
Compare
@nichtich Sorry I just reviewed this PR. I would like to keep both versions and your versions of the class and the schema. Why? Because the maintainer of this schema is @timathom and he might have an existing infrastructure which supports his naming conventions, while it is equally important that there should be an Avram compatible version. So my suggestion: name your Marc21SchemaReader.java to AvramMarc21SchemaReader.java, and I will rename the old one to something like YaleMarc21SchemaReader. For the same reason I will rename the existing schema |
@nichtich I have just modified the existing files, so you can rename your versions. |
Thanks for your consideration, @pkiraly, but there's no need to maintain the naming conventions I used. I haven't yet built anything that depends on them, so, I'm more than happy to align with Avram! |
I fixed the conflicts, now both schema versions and both handlers are available in the code base. |
SonarCloud Quality Gate failed. 0 Bugs 81.4% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Partly resolves #370 by simple modification of the format as listed at timathom/marc-schema#1: