Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to import both Avram and "Yale" format of schema files #373

Closed
pkiraly opened this issue Dec 6, 2023 · 3 comments
Closed

Enable to import both Avram and "Yale" format of schema files #373

pkiraly opened this issue Dec 6, 2023 · 3 comments
Assignees
Labels

Comments

@pkiraly
Copy link
Owner

pkiraly commented Dec 6, 2023

This is needed for the inclusion of #371.

@nichtich
Copy link
Collaborator

No need to do so, as the Yale format is being changed to comply to Avram specification.

@nichtich
Copy link
Collaborator

nichtich commented Apr 4, 2024

Is class YaleMarc21SchemaReader still used? As far as I understand, both the class and src/main/resources/marc/authority-schema.yale.json are only used in test class YaleMarc21SchemaReaderTest but not on production, so they can be removed?

@pkiraly
Copy link
Owner Author

pkiraly commented Apr 4, 2024

The analysis based on the authority schema is not yet in production, but only used in test classes (following a test driven development version). I think you are right, the YaleMarc21SchemaReader could be removed shortly.

@pkiraly pkiraly closed this as completed May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants