Implementation of VRMC_materials_mtoon-1.0 #549

0b5vr · 2020-11-25T04:02:56Z

Why DO NOT MERGE

Depends on WIP: Moving from webpack to rollup, attempt 2 #527
~~Depends on types (GLTFLoader): add definitions about plugin system mrdoob/three.js#20713, GLTFLoader: Make KHR_materials_unlit able to be overridden mrdoob/three.js#20722~~
- Found a workaround for overriding other extensions using beforeRoot
~~VRM 1.0 isn't ready~~
- I'm going to merge this into 1.0 branch
~~The specification of mtoon 1.0 is still subject to change~~

About

This is a candidate implementation of VRMC_materials-mtoon for three-vrm.

TODO

~~Fix the specification~~
Try using various existing models
- Several 0.0 models that are exported from older versions of UniVRM have issues
  - and most of them have incorrect gltf properties that was overridden by 0.0 materialProperties
  - I'm going to merge this anyway for now

…s now union types instead of enums

+ packages/types-vrm-0.0/node_modules + packages/types-vrmc-vrm-1.0/node_modules

Ref: vrm-c/vrm-specification#171

…s PR Ref: vrm-c/vrm-specification#187

Ref: vrm-c/vrm-specification#184

add ignoreVertexColor option

See: vrm-c/vrm-specification#294

largely rewritten the MToonMaterial 😩

…Plugin

…onMaterials` instead

FMS_Cat added 13 commits November 12, 2020 19:53

refactor: make VRM 0.0 schema an individual package

36672bf

refactor: make VRM 1.0 schema an individual package (as of 0a10fcdd)

5866391

fix (types-vrm-0.0, root): materialProperties is array

ce782ac

refactor (types-vrm-0.0): BlendShapePresetName and HumanoidBoneName i…

3a14948

…s now union types instead of enums

chore (CI): Add cache directories

f476ab9

+ packages/types-vrm-0.0/node_modules + packages/types-vrmc-vrm-1.0/node_modules

change (types, vrm1.0): Apply changes of the expression PR

54fb6ef

Ref: vrm-c/vrm-specification#171

change (types, vrm1.0): Apply changes of the expression schema update…

ddf9332

…s PR Ref: vrm-c/vrm-specification#187

change (types, vrm1.0): Apply changes of the meta licenses PR

5114f45

Ref: vrm-c/vrm-specification#184

deps: remove devDeps for each package that are no longer required

7485e7e

feature: add a new package, types-vrmc-materials-mtoon-1.0

c3669ce

refactor: fix a lint issue

6131715

chore: update tsconfig.json

642eec3

fix (types, material): forgot to export union types from index

33fdea4

0b5vr added enhancement New feature or request VRM 1.0 labels Nov 25, 2020

0b5vr added this to the VRM 1.0 milestone Nov 25, 2020

0b5vr self-assigned this Nov 25, 2020

FMS_Cat added 11 commits November 25, 2020 13:10

chore (CI): add a cache path

b7de923

chore (CI): modify use of yarn

fdefd8f

feature: init three-vrm-materials-mtoon

f9b41a4

chore: lint-fix

a9270d2

fix (mtoon-1.0): Fix name conflict of uniform and attribute color

531be91

fix (mtoon-1.0): Add missing parameters to MToonMaterialParameters

e3d803d

docs (mtoon-1.0, examples/importer): fix dnd

97a2a37

change (mtoon-1.0): make it execute onLoadMaterial also when it's copied

4741b49

feature (mtoon-1.0, Importer): add 0.0 compat

8d8a4b6

fix (mtoon-1.0): add a missing dep

fbe5422

chore (CI): add a cache path

84fa67b

0b5vr force-pushed the mtoon-1.0 branch from 4df6fbb to 84fa67b Compare November 25, 2020 04:14

0b5vr mentioned this pull request Jan 28, 2021

Support core features of VRM 1.0 #608

Merged

3 tasks

refactor (1.0, mtoon): trivial

80cab01

0b5vr force-pushed the mtoon-1.0 branch from 8cd480f to 80cab01 Compare June 29, 2021 13:43

FMS_Cat added 4 commits June 30, 2021 12:28

fix (1.0, mtoon): make v0 VRMs ignore vertex colors

e8dfb05

add ignoreVertexColor option

fix (1.0, mtoon): fix more v0 parameters

24040eb

change (1.0, mtoon): Make it ignore vertex colors by default

930f015

See: vrm-c/vrm-specification#294

fix (1.0, mtoon): fix memory leak of textures

de753b3

largely rewritten the MToonMaterial 😩

0b5vr force-pushed the mtoon-1.0 branch from 13f72b3 to de753b3 Compare June 30, 2021 10:52

FMS_Cat added 16 commits June 30, 2021 20:01

examples (1.0, mtoon): make the example dispose unloaded model

2426713

change (1.0, mtoon): VRMCMaterialsMToonExtensionPlugin -> MToonLoader…

966d898

…Plugin

fix (1.0, mtoon): fix extension name

e53ca8b

change (1.0, mtoon): loader plugin, change private methods to protected

da2774d

change (1.0, mtoon): loader plugin, expose parser

d45f542

change (1.0, mtoon): MToonLoaderPlugin -> MToonMaterialLoaderPlugin

a5d450b

examples (1.0, mtoon): rename an example

5b1c900

Merge branch 'schema-package' into mtoon-1.0

ea89939

Merge branch 'schema-package' into mtoon-1.0

d4a231f

example (1.0, mtoon): change extension name to appropriate one

bc6ac1f

change (1.0, mtoon): now it's specVersion conscious

e8dead4

Merge branch 'schema-package' into mtoon-1.0

380a75f

On 1.0-integrated: fix (1.0, mtoon): fix mtoon loader

3e82e56

change (1.0, mtoon): remove onLoadMaterial, use `gltf.userData.vrmMTo…

44c06d7

…onMaterials` instead

change (1.0, mtoon): loader, protected -> private

e58d764

Merge branch '1.0' into mtoon-1.0

38fecfd

0b5vr changed the title ~~[DO NOT MERGE] WIP: Implementation of VRMC_materials_mtoon-1.0~~ Implementation of VRMC_materials_mtoon-1.0 Jul 13, 2021

0b5vr changed the base branch from dev to 1.0 July 13, 2021 10:09

0b5vr mentioned this pull request Jul 13, 2021

chore (1.0): fix a directory name #755

Merged

Merge branch '1.0' into mtoon-1.0

8ac4b9c

0b5vr marked this pull request as ready for review July 13, 2021 10:26

0b5vr merged commit 0195c72 into 1.0 Jul 13, 2021

0b5vr deleted the mtoon-1.0 branch July 13, 2021 10:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of VRMC_materials_mtoon-1.0 #549

Implementation of VRMC_materials_mtoon-1.0 #549

0b5vr commented Nov 25, 2020 •

edited

Loading

Implementation of VRMC_materials_mtoon-1.0 #549

Implementation of VRMC_materials_mtoon-1.0 #549

Conversation

0b5vr commented Nov 25, 2020 • edited Loading

Why DO NOT MERGE

About

TODO

0b5vr commented Nov 25, 2020 •

edited

Loading