-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
types (GLTFLoader): add definitions about plugin system #20713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thank you!
It might be better to hide this one.. i'd be OK with it being a public method, if someone eventually needed it, but if so it should not be prefixed with an underscore. |
Yes, When I implemented the lights extension with the plugin system, I couldn't avoid to extend |
Let's omit it from type defs for now, then. We can un-prefix it and add it later, if it turns out we can't remove it and other extensions need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me (other than exposing _markDefs as commented)
/ping @fms-cat |
thanks for the ping! gonna delete the definition of |
it should not be exposed
@mrdoob ready! |
Thanks! |
Add type definitions about GLTFLoader plugin system which is introduced in #19144 .
Points need review
GLTFLoaderPlugin
as an interface name, which is not explicitly mentioned in anywhere yet. is the name appropriate?_markDefs
in this definitiongetMaterialType
, returnstypeof Material | null
.extendMaterialParams
, returnsPromise<any>